Skip to content

prevent non existing key "bypass_filter_assign_group" in ticket.class…#401

Merged
Rom1-B merged 3 commits intopluginsGLPI:mainfrom
CorentinS6:patch-1
Jan 28, 2026
Merged

prevent non existing key "bypass_filter_assign_group" in ticket.class…#401
Rom1-B merged 3 commits intopluginsGLPI:mainfrom
CorentinS6:patch-1

Conversation

@CorentinS6
Copy link
Contributor

@CorentinS6 CorentinS6 commented Oct 21, 2025 •
edited
Loading

….php

fix PHP Warning (2): Undefined array key "bypass_filter_assign_group" in /var/www/glpi/plugins/escalade/inc/ticket.class.php at line 1270

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes # (issue number, if applicable)
  • Here is a brief description of what this PR does

Screenshots (if appropriate):

@CorentinS6
prevent non existing key "bypass_filter_assign_group" in ticket.class…
b963756 
….php

fix  PHP Warning (2): Undefined array key "bypass_filter_assign_group" in /var/www/glpi/plugins/escalade/inc/ticket.class.php at line 1270
stonebuzz
stonebuzz requested changes Oct 21, 2025
View reviewed changes
@FrancisTicgal
Copy link

FrancisTicgal commented Dec 16, 2025 •
edited
Loading

Hello,
Can we put something like this? The problem I see is when the user does not exist in the escalade_users table.

if (
     $config->fields['use_filter_assign_group']
    && isset($user_config->fields['bypass_filter_assign_group'])
    && !$user_config->fields['bypass_filter_assign_group']
) {
    $condition['id'] = $groups_id_filtered;
}

-- edit
I hadn't seen Corentin's commit, but I agree with him.
If the configuration field were missing, the problem would be different in my opinion, but the existence of the user configuration is not checked, so new users might not have it.

@FrancisTicgal
Copy link

FrancisTicgal commented Dec 16, 2025

I add screenshots for context
image
image
image
image

@CorentinS6 @Rom1-B
Update inc/ticket.class.php
8f9b665 
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@CorentinS6 CorentinS6 requested a review from stonebuzz January 27, 2026 11:56
@stonebuzz
Copy link
Contributor

stonebuzz commented Jan 28, 2026

Please fix CI

CorentinS6
CorentinS6 commented Jan 28, 2026
View reviewed changes
@Rom1-B Rom1-B merged commit d19dbb0 into pluginsGLPI:main Jan 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stonebuzz stonebuzz stonebuzz approved these changes

@Rom1-B Rom1-B Rom1-B approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CorentinS6 @FrancisTicgal @stonebuzz @Rom1-B